rmannibucau commented on code in PR #110:
URL: https://github.com/apache/johnzon/pull/110#discussion_r1351606061
##########
johnzon-core/src/main/java/org/apache/johnzon/core/JsonGeneratorImpl.java:
##########
@@ -449,8 +449,8 @@ public void close() {
try {
if (ex == null) {
flushBuffer();
+ writer.close();
Review Comment:
Hmm, how do we guarantee writer is closed when ex != null? didnt find the
call and I don't see us providing a leaking impl cause we had an exception - we
can request the spec to fix this bug which was not there before if it is
written down if not we just challenge the tck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
