Hi Justin, I think it's ready to be merged. I'll do that and try to cut a release at lunch time. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com
On Thu, Oct 9, 2025 at 9:07 PM Justin Bertram <[email protected]> wrote: > The PR build is green now. > > I had to change the String passed to DateTimeFormatter.ofPattern() > in org.apache.johnzon.mapper.converter.DateConverter since it was using a > character that was only valid in Java 11 (i.e. changed "v" to "z" which > should be equivalent). > > > Justin > > On Thu, Oct 9, 2025 at 1:18 PM Jean-Louis Monteiro < > [email protected]> > wrote: > > > Probably yes, because it's failing only on Java 8. > > So for instance some parts of the java.time API were added after Java 8. > > I did not check the other failures, but probably it's also related to > Java > > 8 issues. > > > > We want to keep Java 8 compatibility on the 1.x branch because of the > > Apache projects using Jonhzon. > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Thu, Oct 9, 2025 at 8:09 PM Justin Bertram <[email protected]> > wrote: > > > > > Looking at the commits on master that aren't on json-1.2.x it appears > > > there's only a couple of fixes that might apply. > > > > > > I sent a PR [1] for these, but the PR build is failing so I'll > > investigate > > > a bit more. Perhaps these aren't valid for 1.2.x. > > > > > > > > > Justin > > > > > > [1] https://github.com/apache/johnzon/pull/133 > > > > > > On Thu, Oct 9, 2025 at 12:28 PM Jean-Louis Monteiro < > > > [email protected]> wrote: > > > > > > > Hi Justin, > > > > > > > > I can definitely help, but it depends on how urgent that is. If it's > > > > urgent, can you help with the backport part? > > > > I can take the release part, with or without the backport from 2.x, > but > > > I'm > > > > not sure I can take the time in the next couple of days to look at > the > > > diff > > > > and do the backports. > > > > > > > > Hopefully it helps > > > > -- > > > > Jean-Louis Monteiro > > > > http://twitter.com/jlouismonteiro > > > > http://www.tomitribe.com > > > > > > > > > > > > On Thu, Oct 9, 2025 at 6:48 PM Justin Bertram <[email protected]> > > > wrote: > > > > > > > > > ActiveMQ Artemis uses Johnzon internally for JSON parsing and > > recently > > > a > > > > > user reported a memory issue [1]. It turns out that the problem is > in > > > > > Johnzon [2] and the fix is already on the 1.2.x branch [3]. > However, > > > > > there's been no release of 1.2.x since that fix was committed. > > > > > > > > > > Is there any chance you guys would do a 1.2.x release soon? It > would > > be > > > > > even better to back-port all the fixes from 2.x before doing so, > but > > if > > > > > that's not an option just the current branch would technically > > suffice > > > to > > > > > resolve this issue. > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > Justin > > > > > > > > > > [1] > https://lists.apache.org/thread/w0bcb3roj2nywk2ok8k3sky9kgmtgomc > > > > > [2] https://issues.apache.org/jira/browse/JOHNZON-396 > > > > > [3] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/johnzon/commit/664cb73f629fd0190902a0f1080c420a509e66b0 > > > > > > > > > > > > > > >
