Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131960
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V get(Object key) {
- if (logger.isLoggable(Level.FINEST)) {
- logger.finest("Cache get key: " + key.toString());
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Cache get key: {}", key.toString());
}
return super.get(key);
}
@Override
public V put(K key, V value) {
-
- if (logger.isLoggable(Level.FINEST)) {
- logger.finest("Cache put key: " + key.toString());
+ if (LOG.isDebugEnabled()) {
--- End diff --
I'd remove the check and the toString here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
