Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131968
--- Diff: src/main/java/org/apache/joshua/util/CompareGrammars.java ---
@@ -101,13 +100,12 @@ public static void compareValues(File grammarFile1,
File grammarFile2, String fi
float diff = (diff1 < diff2) ? diff1 : diff2;
if (diff > delta) {
- logger.fine("Line " + counter + ": Score mismatch: " + score1 +
" vs " + score2);
+ LOG.debug("Line {}: Score mismatch: {} vs {}", counter, score1,
score2);
set.add(line1);
totalOverDiffs += diff;
- } else if (logger.isLoggable(Level.FINEST)) {
- logger.finest("Line " + counter + ": Scores MATCH: " + score1 +
" vs " + score2);
+ } else if (LOG.isDebugEnabled()) {
--- End diff --
I think we can remove the isDebugEnabled check here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
