Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/d4fdbfd88bab99e244d3ed1fc9cff4ba5e6d124c#commitcomment-18742703
The whole static global feature index is a mess. You've gotten rid of the
dense feature indices on the 7 branch. What if we get rid of the global state
index as well? We could fix this in initializeFeatureFunctions, with the
following test:
...
this.featureFunctions.add(feature);
int stateIndex = 0;
if (feature instanceof StatefulFF) {
feature.setStateIndex(stateIndex);
stateIndex++;
}
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
