[
https://issues.apache.org/jira/browse/JSPWIKI-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Santos RodrÃguez closed JSPWIKI-712.
-----------------------------------------------
closing resolved issues for 2.10.1
> Entities in ChangeNote should be decoded when "keep editing"
> ------------------------------------------------------------
>
> Key: JSPWIKI-712
> URL: https://issues.apache.org/jira/browse/JSPWIKI-712
> Project: JSPWiki
> Issue Type: Bug
> Components: Default template
> Affects Versions: 2.8.4, 2.9
> Environment: Windows XP, Tomcat 7.0
> Reporter: Vigneshwaran Raveendran
> Assignee: brushed
> Priority: Minor
> Labels: fix, javascript
> Fix For: 2.10.1
>
> Attachments: JSPWIKI-712-test1.png, JSPWIKI-712-test2.png,
> JSPWIKI-712-test3.png, JSPWIKI-712.patch
>
>
> Steps to reproduce the bug:-
> 1. Go here: http://doc.jspwiki.org/2.4/Edit.jsp?page=WindowsInstall
> 2. Type in changenote: Testing "quotes" & ampersand
> 3. Click preview
> 4. Click Keep Editing
> 5. The changenote looks like this: Testing "quotes"
> & ampersand
> Now the user has to remove it and type (Testing "quotes" & ampersand) again
> before saving. If the user didn't notice it, then the comment will be saved
> as "Testing "quotes" & ampersand" in the history.
> =================================================
> I know that entities need to be encoded for security reasons but this is a
> Bug.
> When "keep editing" button is clicked, the comment should appear in decoded
> format. For that, there should be a javascript that execute "after" the page
> is loaded. No need to change any of the TextUtil.replaceEntities() methods.
> =================================================
> This is how I fixed it in my pc:
> 1. Added the following script to commonheader.jsp (or prettify.js)
> <script type="text/javascript">
> function decodeChangeNote() {
> document.getElementById("changenote").value =
> document.getElementById("changenote").value
> .replace(/&amp;/g,"&")
> .replace(/&lt;/g,"<")
> .replace(/&gt;/g,">")
> .replace(/&quot;/g,"\"");
> }
> </script>
> 2. Changed <body> tag in EditTemplate.jsp to call this js function on load.
> <body onload="decodeChangeNote()">
> ====================================================
> Now JSPWiki works fine for me. Polish this fix if needed and commit it.
> Please correct me if I'm wrong.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
