spyhunter99 opened a new pull request, #405: URL: https://github.com/apache/jspwiki/pull/405
Root issue is that when uploading a large file (larger than the configured max), the browser gets a 302 redirect, however in my experience, it just displays a connection closed message. The response looks like it should be ok otherwise. Anyhow, the fix is to ensure that the uploader rejects the files that are too big and redirects to the upload attachment page by simply moving the logic around in the servlet. This change, while it addresses the issue, might cause a new issue whereby uploading an extremely large file might cause OOM errors since the commons file uploader parses and buffers the whole http request. And the way the upload page works, it is not possible to get the correct redirect url without parsing the request. unfortunately, i don't think there's a way to add an http header to multipart form post from javascript. open to other opinions on this or if the risk is worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
