spyhunter99 commented on code in PR #405:
URL: https://github.com/apache/jspwiki/pull/405#discussion_r2553132540
##########
jspwiki-main/src/main/java/org/apache/wiki/attachment/AttachmentServlet.java:
##########
@@ -399,15 +415,26 @@ protected String upload( final HttpServletRequest req )
throws RedirectException
final UploadListener pl = new UploadListener();
m_engine.getManager( ProgressManager.class ).startProgress( pl,
progressId );
-
+ if
("chunked".equalsIgnoreCase(req.getHeader("Transfer-Encoding"))) {
Review Comment:
> let the container try to save the file
So reading the docs for commons file upload what we currently have is
correct for handling large files with memory efficiency. I must have
misinterpreted or missed the fact that we are using the disk item factory for
this. I'll double check everything but i think we can remove the chunked
encoding part. sounds like the servlet container takes care for that for us
anyhow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
