spyhunter99 commented on PR #407: URL: https://github.com/apache/jspwiki/pull/407#issuecomment-3568606089
> Hi, > > I see several things here: > > * the new portable build shouldn't be necessary, mvn verify -Pintegration-tests should run the appropiate tests on that module > > * new methods on Session public API (see details below); perhaps those checks could be done internally, although that would mean roles not noted on web.xml would be needing to be noted elsewhere (the wiki-properties?). I understand the need, don't know the best way to accomplish it > > * if the existing ACL syntax still works, as is, using the new AclManager, I'd rather merge both AclManagers into one than keeping them separate. It's a useful functionality so it would be easier to use if there's no need of setting an extra parameter thanks for the feedback. I must have missed the notification on this one. I don't think the existing ACL syntax works here. since this is explicitly looking for AND/OR/NOT. perhaps it can be adjusted to assume an OR statement whereby no operator is specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
