spyhunter99 commented on code in PR #407:
URL: https://github.com/apache/jspwiki/pull/407#discussion_r2557935873
##########
jspwiki-api/src/main/java/org/apache/wiki/api/core/Session.java:
##########
@@ -250,5 +252,21 @@ public interface Session extends WikiEventListener {
static Object doPrivileged( final Session session, final
PrivilegedAction<?> action ) throws AccessControlException {
return Subject.doAsPrivileged( session.getSubject(), action, null );
}
+
+ /**
+ * sets the raw http servlet request object. typically used for
+ * verifying externally defined access controls.
+ * @since 3.0.0
+ * @param session
+ */
+ void setHttpRequestContext(HttpServletRequest session);
+
+ /**
+ * gets the raw http servlet request object. typically used for
+ * verifying externally defined access controls. Result may be null
+ * @since 3.0.0
+ * @return HttpServletRequest
+ */
+ HttpServletRequest getHttpRequestContext();
Review Comment:
so the reason for the api change is that the interfaces have default
implementations which do not have access to a wiki context, wiki session or
wiki engine. I can move the code from the default implementation in the
interface to the concrete versions or duplicate it so that nothing breaks. Your
call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
