[ 
https://issues.apache.org/jira/browse/JSPWIKI-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134342#comment-18134342
 ] 

Arturo Bernal commented on JSPWIKI-8:
-------------------------------------

Checked in the current code (master, 3.0.1-SNAPSHOT) and on a running instance 
(Tomcat 10.1, Chrome).

LDAP: the user databases in org.apache.wiki.auth.user are XMLUserDatabase, 
JDBCUserDatabase and DummyUserDatabase; there is no LDAP implementation, and 
jspwiki.properties only mentions LDAP to map roles to groups. So the comment of 
2010 that the LDAP support for user databases came with 3.0.0 is not reflected 
in the code today, and what the description needs, taking the full name and the 
wiki name from LDAP attributes, is still missing.

Capitalization: TextUtil.cleanString (in jspwiki-util) upper-cases the first 
letter of each word when it builds a page name from text, and it has no switch 
to turn that off. In the running wiki, opening the editor for 
page=lowercasetest gives the page Lowercasetest. I found no property for this 
in jspwiki.properties, so I could not confirm the setting that Alex remembered.

Limits: I did not run container authentication against an LDAP server, so the 
exact places of the report (the greeting and the last changed by line) were not 
tried. I leave the issue open as an improvement.

> Links generated related to login name are incorrect (casing incorrect)
> ----------------------------------------------------------------------
>
>                 Key: JSPWIKI-8
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-8
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Templates and UI
>         Environment: linux/debian, tomcat5.5, jspwiki 2.4.73 and jspwiki 
> 2.5.139-beta, ldap/container authorization
>            Reporter: Joerg Meyer
>            Assignee: Andrew R. Jaquith
>            Priority: Minor
>             Fix For: STRIPES/JCR-3.0
>
>
> ! Background
> The tests were done using the brushed template on 2.4.73 and standard on 
> 2.5.139-beta.
> Since most issues are similar, i believe, that the template does not affect 
> the issues. However brushed template and standard template on 2.5.139-beta 
> react differently to userFavorites.
> If issues are known to exist only in the brushed template please ignore the 
> entries.
> Our corporate template is at the moment a modified css for brushed template 
> (extra vanilla) for 2.4.73, however we are trying to create a standalone 
> template for standard 2.5.139-beta.
> Note: On the results for favorites, the tests where done with either 
> jmeyerFavorites or JmeyerFavorites existing.
> When i login using my ldap name: "jmeyer" i get the following results:
> ! 2.4.73
> * "G'day, jmeyer" points to page "Jmeyer" instead of "jmeyer"
> * "This page (revision-11) was last changed on 22-Oct-07 11:18 AM, +0900 by 
> jmeyer" points to "Jmeyer" instead of "jmeyer"
> * User in "RecentChanges" is correctly "jmeyer" and points to "jmeyer"
> * "jmeyerFavorites" is correctly included, the link "Favorites" points 
> correctly to the link "jmeyerFavorites"
> * "JmeyerFavorites" does not get included, no "Favorites" box
> * creating a page with first letter lowercase will automatically "rename" it. 
> I.e. "jmeyerFavorites" to "JmeyerFavorites" (this makes it impossible to 
> create favorites)
> * if a page with first letter lowercase already exists, editing it will not 
> rename it
> * renaming any page to first letter lowercase will automatically generate a 
> page with first letter uppercase
> (this makes it impossible to rename any page to correct user pages or 
> favorites)
> * It seems that the page "jmeyer" cannot be renamed
> (this may be true for all pages starting with a lowercase letter)
> * going to a page "jmeyer" when there is only a page "Jmeyer" will resolve 
> correctly
> * going to a page "Jmeyer" when there is only a page "jmeyer" will try to 
> create the page "Jmeyer"
> * weather a page can be found or not has no impact on the link marking when 
> the case does not match exactly
> ! 2.5.139-beta
> * "G'day, jmeyer (authenticated)" points to page "Jmeyer" instead of jmeyer
> * "This page (revision-23) was last changed on 25/10 by jmeyer" points to 
> "Jmeyer" instead of "jmeyer"
> * User in "RecentChanges" is correctly "jmeyer" and points to "jmeyer"
> * "jmeyerFavorites" is correctly included, however the link "Favorites" 
> points to "JmeyerFavorites" instead of "jmeyerFavorites"
> * "JmeyerFavorites" does not get included, however "Favorites" box gets 
> created (shows this site does not exist on expanding), the link  "Favorites" 
> points to "JmeyerFavorites"
> * creating a page with first letter lowercase will automatically "rename" it 
> "jmeyerFavorites" to "JmeyerFavorites"
> * if a page with first letter lowercase already exists, editing it will not 
> rename it
> * It seems that the page "jmeyer" cannot be renamed
> * going to a page "jmeyer" when there is only a page "Jmeyer" will resolve 
> correctly
> * going to a page "Jmeyer" when there is only a page "jmeyer" will try to 
> create the page "Jmeyer"
> * renaming any page to first letter lowercase will automatically generate a 
> page with first letter uppercase
> * weather a page can be found or not has no impact on the link marking when 
> the case does not match exactly
> ! Result
> Weather page names should start with an upper case letter or not is 
> irrelevant to the the discussion of correct user names. 
> If, as in our case, the login names are generally lowercase, then none of the 
> automatically created links except the RecentChanges will be generated 
> correctly. In most cases user pages cannot be created at all.
> Changing the login name to a different field in ldap (i.e. full name) has 
> other issues, as spaces in names may get resolved in "G'day ..." however 
> RecentChanges will never have links.
> This is also not really a solution in our case, as all other applications and 
> portals throughout the company use the login name.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to