arturobernalg opened a new pull request, #572: URL: https://github.com/apache/jspwiki/pull/572
The description of an entry in the RSS feed of a page took the version before the one described as `version - 1`, as the FIXME in `DefaultRSSGenerator` said. When that version had been deleted, reading it failed with a `ProviderException`, which was logged twice, and its text was taken as empty, so the entry showed the whole page as added. The entry is now diffed against the latest version that still exists before the one described. A page without an earlier version is described as created, as before. Measured with `VersioningFileProvider` and the `SvnStyleDiffProvider`: a page saved three times with version 2 deleted. On master the entry for version 3 shows the line that did not change as added; with this change it is shown as unchanged. The new `RSSGeneratorVersionsTest` has three tests; on master the one with the deleted version fails and the other two pass, with this change all three pass, and `RSSGeneratorTest` still passes. I did not run the whole test suite. https://issues.apache.org/jira/browse/JSPWIKI-1320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
