arturobernalg opened a new pull request, #584: URL: https://github.com/apache/jspwiki/pull/584
https://issues.apache.org/jira/browse/JSPWIKI-1352. This is the update of JDOM that Dependabot proposes in #430, with the change it needs. JDOM 2.0.6.1 sets the SAX features external-general-entities and external-parameter-entities on its reader and throws if the reader does not know them. The reader is the HTML parser of htmlunit-neko, which never resolves external entities and does not know those features, so with 2.0.6.1 alone the translator of the WYSIWYG editor fails, and so does the conversion of the wiki pages to Markdown while the war is built. The filter around the parser accepts the setting of those two features now. Checked locally: the tests of jspwiki-wysiwyg (19), jspwiki-markdown (17) and a third module (10) that fail with 2.0.6.1 alone pass; all the unit tests pass with the same counts as master (1028 in jspwiki-main); the war builds, and on a running war (Tomcat 10.1) I registered a user, logged in, saved a page with markup and used the HTML to wiki translator, with the same results as master. Not tested: the integration tests, and browsers other than Chromium. LICENSE is updated; the entry of the ChangeLog comes in a separate commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
