spyhunter99 commented on code in PR #584:
URL: https://github.com/apache/jspwiki/pull/584#discussion_r4498279309
##########
jspwiki-wysiwyg/src/main/java/org/apache/wiki/htmltowiki/HtmlStringToWikiTranslator.java:
##########
@@ -144,10 +149,29 @@ public static String element2String( final Element
element ) {
*/
private static final class AttributeUriFilter extends XMLFilterImpl {
+ private static final Set< String > EXTERNAL_ENTITY_FEATURES = new
HashSet<>( Arrays.asList(
+ "http://xml.org/sax/features/external-general-entities";,
+ "http://xml.org/sax/features/external-parameter-entities"; ) );
Review Comment:
aren't these almost always disabled for security reasons? do we have
anything that needs these enabled? sorry i don't understand how jdom is used in
this context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
