----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/#review29412 -----------------------------------------------------------
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56636> We can just add messageSet to queue directly. In this test, topicInfo is irrelevant. core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56637> We probably should just use ConsumerConfig.ConsumerTimeoutMs here, to make it clear that we don't want to timeout. core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56640> To really test that we can iterate over messages with decoding errors, could we have the first half of messages with decoding errors and the second half without, and make sure that we get the correct offsets when iterating messages in the second half? core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56639> Instead of throwing an exception, we should fail the test. core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56638> Not sure why this is useful. ConsumedOffset is a val and will never change. - Jun Rao On Nov. 25, 2013, 8:55 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15805/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2013, 8:55 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1140 > https://issues.apache.org/jira/browse/KAFKA-1140 > > > Repository: kafka > > > Description > ------- > > KAFKA-1140.v2 > > > KAFKA-1140.v1 > > > Dummy > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > a4227a49684c7de08e07cb1f3a10d2f76ba28da7 > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala > ef1de8321c713cd9d27ef937216f5b76a5d8c574 > > Diff: https://reviews.apache.org/r/15805/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
