----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/#review29465 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsumerIterator.scala <https://reviews.apache.org/r/15805/#comment56691> It seems that we can leave ConsumerIterator mostly unchanged and just instantiate MessageAndMetadata differently. core/src/main/scala/kafka/message/MessageAndMetadata.scala <https://reviews.apache.org/r/15805/#comment56692> We should name this method message() to maintain the same api. Then, there is no need for code change in consumer apps. core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56694> Could we reference it as the predefined value ConsumerConfig.ConsumerTimeoutMs? core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala <https://reviews.apache.org/r/15805/#comment56693> Let's make sure iter.hasNext() returns true too. - Jun Rao On Nov. 26, 2013, 10:41 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15805/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 10:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1140 > https://issues.apache.org/jira/browse/KAFKA-1140 > > > Repository: kafka > > > Description > ------- > > KAFKA-1140.v3 > > > KAFKA-1140.v2 > > > KAFKA-1140.v1 > > > Dummy > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > dc066c23e9c221ebe4ba9fcdcde5ba26f959095e > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > a4227a49684c7de08e07cb1f3a10d2f76ba28da7 > core/src/main/scala/kafka/message/MessageAndMetadata.scala > 20c0e7004282c5a71228bc04adab7f1997cb5b98 > core/src/main/scala/kafka/tools/MirrorMaker.scala > f0f871c22dea30ae66508d0ba00597e3254eab72 > core/src/main/scala/kafka/tools/ReplayLogProducer.scala > 814d61ae477cef5e56723e1f1a86c3b2e9b7c1ea > core/src/test/scala/other/kafka/TestLogCleaning.scala > 22b16e54980e30f60dbf2fbe46c16398d654ba21 > core/src/test/scala/other/kafka/TestZKConsumerOffsets.scala > 31534ca303e91853e707644fde96783cfbe4322e > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala > ef1de8321c713cd9d27ef937216f5b76a5d8c574 > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > 8fe7259c9abd2c883e423a1ea7ea19c367f0c1a4 > > core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala > 43af649f3297644e8caea176a79cadde745be2a4 > examples/src/main/java/kafka/examples/Consumer.java > 13135b954f3078eeb7394822b0db25470b746f03 > perf/src/main/scala/kafka/perf/ConsumerPerformance.scala > ec3cd295266e162cd884799b491ae48a51ac8f10 > > Diff: https://reviews.apache.org/r/15805/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
