----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19338/#review37525 -----------------------------------------------------------
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala <https://reviews.apache.org/r/19338/#comment69072> Ideally, we should use something like mapAsScalaMap in 2.9.x - basically the direct conversion methods are different between 2.8.x and 2.9.x. That's why I'm doing it indirectly here. - Joel Koshy On March 18, 2014, 1:37 a.m., joel koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19338/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 1:37 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1309 > https://issues.apache.org/jira/browse/KAFKA-1309 > > > Repository: kafka > > > Description > ------- > > fix > > > Diffs > ----- > > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala > 6de320dcc0d9373dd046bda0ea68a9c9f8931630 > > Diff: https://reviews.apache.org/r/19338/diff/ > > > Testing > ------- > > > Thanks, > > joel koshy > >
