> On March 18, 2014, 1:47 a.m., Neha Narkhede wrote: > > Ship It!
Thanks for the review - actually, now that I look at it I don't recollect why it needed to be a mutable.map. Will revisit this tomorrow. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19338/#review37526 ----------------------------------------------------------- On March 18, 2014, 1:37 a.m., joel koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19338/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 1:37 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1309 > https://issues.apache.org/jira/browse/KAFKA-1309 > > > Repository: kafka > > > Description > ------- > > fix > > > Diffs > ----- > > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala > 6de320dcc0d9373dd046bda0ea68a9c9f8931630 > > Diff: https://reviews.apache.org/r/19338/diff/ > > > Testing > ------- > > > Thanks, > > joel koshy > >
