> On April 8, 2014, 4:53 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/network/RequestChannel.scala, lines 163-165 > > <https://reviews.apache.org/r/20034/diff/1/?file=549058#file549058line163> > > > > Do we still need this?
This is still used in some unit tests, in which they do need blocking behavior. > On April 8, 2014, 4:53 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, lines 274-275 > > <https://reviews.apache.org/r/20034/diff/1/?file=549059#file549059line274> > > > > Idle time should just be the time in doing socket select. It actually is just recording the socket select() function, no? - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39792 ----------------------------------------------------------- On April 4, 2014, 5:44 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20034/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 5:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1353 > https://issues.apache.org/jira/browse/KAFKA-1353 > > > Repository: kafka > > > Description > ------- > > KAFKA-1353.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/network/RequestChannel.scala > a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 > core/src/main/scala/kafka/network/SocketServer.scala > dcfca3f4156957b0006ba9bfdeca848c115825a8 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > 871212bf9110ca95ca7d2109be070f69d0f90247 > > Diff: https://reviews.apache.org/r/20034/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
