----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39819 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/20034/#comment72478> Is there value in including Broker-id in the bean name? How about NetworkProcessorAvgIdlePercent and NetworkProcessor-id-IdlePercent? core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/20034/#comment72476> No longer used. core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/20034/#comment72477> The way that we use meter is a bit tricky. Could you add some comments on the logic behind it and why we need to do the division? core/src/main/scala/kafka/server/KafkaRequestHandler.scala <https://reviews.apache.org/r/20034/#comment72479> The idle time needs to be computed inside the while loop. Otherwise, if there is no new request, the metrics is not updated. core/src/main/scala/kafka/server/KafkaRequestHandler.scala <https://reviews.apache.org/r/20034/#comment72480> Same comment on broker id. For the name, will RequestHandlerAvgIdlePercent be better? - Jun Rao On April 8, 2014, 5:41 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20034/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 5:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1353 > https://issues.apache.org/jira/browse/KAFKA-1353 > > > Repository: kafka > > > Description > ------- > > KAFKA-1353.v2 > > > KAFKA-1353.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/network/RequestChannel.scala > a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 > core/src/main/scala/kafka/network/SocketServer.scala > dcfca3f4156957b0006ba9bfdeca848c115825a8 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > 871212bf9110ca95ca7d2109be070f69d0f90247 > > Diff: https://reviews.apache.org/r/20034/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
