Hi Randall. I'd also love to enable MDC by default. However I agree with your concerns regarding compatibility. Runtime logs are a form of public interface (as I believe has been discussed before) and therefore enabling MDC in the console requires a major version bump. Now, enabling it only for the file output, indeed, would not be backwards incompatible, given that this is a new configuration. However, same as you, I also err on the side of keeping these two views (console and file logs) in sync for the sake of simplicity. This will also allow users to keep changing settings for both loggers in one place, which I suspect will cover most of the common and simple use cases.
So I think we agree, MDC still remains only one line change away but soon will become the default option. Thanks for your thoughts! Konstantine On Mon, Sep 16, 2019 at 6:42 PM Randall Hauch <rha...@gmail.com> wrote: > Thanks for tackling this, Konstantine. > > The KIP looks great. My only question is about whether to enable the recent > MDC variable in the file log format, but for backward compatibility reasons > keep it as-is for the console. I suspect using the same format in the log > files and the console would be preferred, and to have users change it in > one place. WDYT? > > Randall > > On Wed, Sep 11, 2019 at 7:06 PM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Thanks Gwen! > > Indeed, it's a common setup and it's been missing for some time. I agree, > > it'll be nice to have this in place by default. > > I'm guessing previous attempts missed that such a change needs a KIP. > > > > Cheers, > > Konstantine > > > > > > > > On Wed, Sep 11, 2019 at 2:16 PM Gwen Shapira <g...@confluent.io> wrote: > > > > > Great idea. It will greatly improve the ops experience. Can't believe > > > we didn't do it before. > > > > > > On Wed, Sep 11, 2019 at 2:07 PM Konstantine Karantasis > > > <konstant...@confluent.io> wrote: > > > > > > > > *** Missed the [DISCUSS] tag in the previous email. Reposting here, > > > please > > > > reply in this thread instead *** > > > > > > > > Hi all. > > > > > > > > While we are in the midst of some very interesting KIP discussions, > I'd > > > > like to bring a brief and useful KIP on the table as well. > > > > > > > > It's about enabling redirection of log4j logging to a file for Kafka > > > > Connect by default, in a way similar to how this is done for Kafka > > > brokers > > > > today. > > > > > > > > You might find it short and straightforward but, still, needs to be > > > > discussed as a KIP since it's an externally visible (yet compatible) > > > change > > > > in how Connect logs its status during runtime. > > > > > > > > Here's a link to the KIP: > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-521%3A+Enable+redirection+of+Connect%27s+log4j+messages+to+a+file+by+default > > > > > > > > Looking forward to your comments! > > > > Konstantine > > > > > >
