Sounds good, thanks. Guozhang
On Fri, Nov 8, 2019 at 9:26 AM Xavier Léauté <xav...@confluent.io> wrote: > > > > 1. I do feel there're similar needs for clients make JMX configurable. > Some > > context: in modules like Connect and Streams we have added / refactored a > > large number of metrics so far [0, 1], and although we've added a > reporting > > level config [2] to clients, this is statically defined at code and > cannot > > be dynamically changed either. > > > > Thanks for providing some context there, I have updated the KIP to add > equivalent configs for clients, streams, and connect > > > > 2. This may be out of the scope of this KIP, but have you thought about > how > > to make the metrics collection to be configurable (i.e. basically for > those > > metrics which we know would not be exposed, we do not collect them > either) > > dynamically? > > > Yes, given what you described above, it would make sense to look into this. > One difficulty though, is that we'd probably want to define this at the > sensor level, > which does not always map to the metric names users understand. > > There are also cases where someone may want to expose different sets of > metrics > using different reporters, so I think a reporting level config is still > useful. > For this KIP, I am proposing we stick to making reporting configurable, > independent of the underlying collection mechanism. > -- -- Guozhang
