----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20997/#review42028 -----------------------------------------------------------
The patch failed to apply on trunk. Will complete my review once you update the diff. core/src/main/scala/kafka/producer/ConsoleProducer.scala <https://reviews.apache.org/r/20997/#comment75774> It will be cleaner to move this logic into a buildProducerConfig private API that builds either the new or old producer's configs based on some boolean value. core/src/main/scala/kafka/producer/TransitProducer.scala <https://reviews.apache.org/r/20997/#comment75775> +1 on renaming this as per Jun's suggestion. If this is only for the tools, then let's move it to the tools package. - Neha Narkhede On May 1, 2014, 11:46 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20997/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 11:46 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1432 > https://issues.apache.org/jira/browse/KAFKA-1432 > > > Repository: kafka > > > Description > ------- > > 1. Add useNewProducer in the MirrorMaker. > 2. Remove MirrorMaker's dependency on MigrationTool's producer thread and > data channel. > 3. Unify Old/New Producer in a new class for MirrorMaker, ProducerPerformance > and ConsoleProducer > > Will remove kafka.tools.newproducer.MirrorMaker upon final commit. > > > Diffs > ----- > > core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala > 988e4374d8c9b30c9333369741c30c75f0c44f2c > core/src/main/scala/kafka/producer/ConsoleProducer.scala > b19ab49c5fd57423e142f2f8afc5a77e653fd6ed > core/src/main/scala/kafka/producer/TransitProducer.scala PRE-CREATION > core/src/main/scala/kafka/tools/MirrorMaker.scala > e4d1a86f673f7df7fe71ce44e3550fcde8d01bba > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 1490bdb3d52d5c901d7a464222284935bda2f7ca > > Diff: https://reviews.apache.org/r/20997/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
