> On May 2, 2014, 5:51 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/producer/ConsoleProducer.scala, line 50 > > <https://reviews.apache.org/r/20997/diff/1/?file=573267#file573267line50> > > > > It will be cleaner to move this logic into a buildProducerConfig > > private API that builds either the new or old producer's configs based on > > some boolean value. > > Guozhang Wang wrote: > The thing is that this buildProducerConfig would not be able to be shared > between ConsoleProducer and ProducerPerformance since the former used its own > ProducerConfig while the latter used its own ProducerPerfConfig. So we would > have two buildProducerConfig functions in these two classes and just move the > logic there. I think it would not help much for the cleaning.
makes sense. > On May 2, 2014, 5:51 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/producer/TransitProducer.scala, lines 24-25 > > <https://reviews.apache.org/r/20997/diff/1/?file=573268#file573268line24> > > > > +1 on renaming this as per Jun's suggestion. > > > > If this is only for the tools, then let's move it to the tools package. > > Guozhang Wang wrote: > ConsoleProducer is in kafka.producer > ProducerPerformance is in kafka.perf > MirrorMaker is in kafka.tools > > So I decided to put the BaseProducer in kafka.producer. Let me know if > you have another preference. ConsoleProducer is a tool and should be moved to kafka.tools ProducerPerformance is also supposed to be in kafka.tools. It seems to me that it's better to do these moves and also move BaseProducer to kafka.tools. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20997/#review42028 ----------------------------------------------------------- On May 5, 2014, 5:31 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20997/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 5:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1432 > https://issues.apache.org/jira/browse/KAFKA-1432 > > > Repository: kafka > > > Description > ------- > > Address Jun's comments > > > Add new TransitProducer > > > KAFKA-1432.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION > core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala > 988e4374d8c9b30c9333369741c30c75f0c44f2c > core/src/main/scala/kafka/producer/ConsoleProducer.scala > b19ab49c5fd57423e142f2f8afc5a77e653fd6ed > core/src/main/scala/kafka/tools/MirrorMaker.scala > e4d1a86f673f7df7fe71ce44e3550fcde8d01bba > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 1490bdb3d52d5c901d7a464222284935bda2f7ca > system_test/utils/kafka_system_test_utils.py > 423b512983c77b41b819912fe67b375a78faf644 > > Diff: https://reviews.apache.org/r/20997/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
