Hey all, I removed the table for the ZK metric and specified that `kafka.controller:type=KafkaController` is used by both ZK and Quorum controllers.
Best, Ryan Dielhenn On 2021/06/14 17:56:59, Xavier Léauté <xav...@confluent.io.INVALID> wrote: > Any reason we need two different metrics for ZK an Quorum based controllers? > Wouldn't it make sense to have one metric that abstracts the implementation > detail? > > On Mon, Jun 7, 2021 at 2:29 PM Ryan Dielhenn <rdielh...@confluent.io.invalid> > wrote: > > > Hey Colin and David, > > > > I added another table for the ZK version of RegisteredBrokerCount. > > > > Best, > > Ryan Dielhenn > > > > On 2021/06/04 08:21:27, David Jacot <dja...@confluent.io.INVALID> wrote: > > > Hi Ryan, > > > > > > Thanks for the KIP. > > > > > > +1 for adding RegisteredBrokerCount to the ZK controller as well. This > > > would be really helpful. > > > > > > Best, > > > David > > > > > > On Fri, Jun 4, 2021 at 12:44 AM Colin McCabe <cmcc...@apache.org> wrote: > > > > > > > Hi Ryan, > > > > > > > > Thanks for the KIP. I think it would be good to provide the > > > > RegisteredBrokerCount metric for the ZK controller as well as for the > > > > Quorum controller. Looks good aside from that! > > > > > > > > best, > > > > Colin > > > > > > > > On Thu, Jun 3, 2021, at 14:09, Ryan Dielhenn wrote: > > > > > Hey kafka-dev, > > > > > > > > > > I created KIP-748 as a proposal to add broker count metrics to the > > > > > Quorum Controller. > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-748%3A+Add+Broker+Count+Metrics#KIP748:AddBrokerCountMetrics > > > > > > > > > > Best, > > > > > Ryan Dielhenn > > > > > > > > > > > > > > >
