> On Wed, Jul 13, 2022 at 10:01 AM Sagar <sagarmeansoc...@gmail.com> wrote: > > Well actually I have 2 approved PRs from Kafka Connect: > > > > https://github.com/apache/kafka/pull/12321 > > https://github.com/apache/kafka/pull/12309 > > > > Not sure how to get these merged though but I think these can go into 3.3 > > release. > > Thank you for the fixes. What do you think Chris Egerton since you > reviewed them and merged them into trunk?
I think these are useful contributions but probably not worth backporting at this stage. They do not address regressions and they do not impact the stability of the release. I am looking forward to having https://github.com/apache/kafka/pull/12309 in 3.4/4.0, though! > On Thu, Jul 28, 2022 at 2:16 PM Chris Egerton <fearthecel...@gmail.com> wrote: > > Would it be okay to backport https://github.com/apache/kafka/pull/12451 to the current 3.3 branch? It's a strictly cosmetic change that updates a misleading comment about exactly-once support for source connectors. I'm hoping it'll make life easier for anyone who has to debug this feature by saving some confusion. > > Yes. Feel free to cherry pick it to the 3.3.0 branch. As you said, it > is mainly a formatting change and a comment change. It should be low > risk. > > Thanks! Thanks José! Will get on that now. Cheers, Chris On Thu, Aug 4, 2022 at 11:32 AM José Armando García Sancio <jsan...@confluent.io.invalid> wrote: > On Mon, Aug 1, 2022 at 1:51 AM Matthew Benedict de Detrich > <matthew.dedetr...@aiven.io.invalid> wrote: > > Due to time pressure from the release schedule does it make sense to > merge the PR as is since it already has the necessary approval from Luke or > should we wait for finale reviews from Mickael/Tom as well? > > Thanks for the update Matthew. You can try tagging them with their > GitHub alias in the PR. > > -- > -José >
