Hi Sophie, I was trying to understand the goal of the change and it's not totally clear to me. If the goal is to allow third party applications to customize the logging behavior, why is the method protected instead of public?
Ismael On Thu, Nov 2, 2023 at 9:55 PM Sophie Blee-Goldman <sop...@responsive.dev> wrote: > Hey all, > > This is a trivial one-liner change that it was determined should go through > a KIP during the PR review process (see this thread > <https://github.com/apache/kafka/pull/14681#discussion_r1378591228> for > context). Since the change itself was already reviewed and approved I'm > skipping the discussion thread and bringing it to a vote right away, but of > course I'm open to feedback and can create a discussion thread if there is > need for it. > > The change itself is simply adding the `protected` modifier to the > ProducerConfig constructor that allows for silencing the config logging. > This just brings the ProducerConfig in alignment with the other client > configs, all of which already had this constructor as protected. > > KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-998%3A+Give+ProducerConfig%28props%2C+doLog%29+constructor+protected+access > PR: https://github.com/apache/kafka/pull/14681 > > Thanks! > Sophie >
