Hi Jose, I updated the KIP to include a new metric for deprecated request api versions and also a new attribute in the request log to make it easy to find such entries,
Thanks, Ismael On Thu, Jan 12, 2023 at 1:03 AM Ismael Juma <ism...@juma.me.uk> wrote: > Hi Jose, > > I think it's reasonable to add more user-friendly metrics as you > described. I'll update the KIP soon with that. I'll try to define them in a > way where they track deprecated protocols for the next major release. That > way, they can be useful even after AK 4.0 is released. > > Ismael > > On Wed, Jan 11, 2023 at 12:34 PM José Armando García Sancio > <jsan...@confluent.io.invalid> wrote: > >> Thanks Ismael. >> >> > The following metrics are used to determine both questions: >> > > >> > > - Client name and version: >> > > >> kafka.server:clientSoftwareName=(client-software-name),clientSoftwareVersion=(client-software-version),listener=(listener),networkProcessor=(processor-index),type=(type) >> > > - Request name and version: >> > > >> kafka.network:type=RequestMetrics,name=RequestsPerSec,request=(api-name),version=(api-version)} >> > > >> > > >> > Are you suggesting that this is too complicated and hence we should add >> a >> > metric that tracks AK 4.0 support explicitly? >> >> Correct. It doesn't look trivial for the users to implement this check >> against the RequestMetrics. I was wondering if it is worth it for >> Kafka to implement this for them and expose a simple metric that they >> can check. >> >> -- >> -José >> >
