+1 (binding) I have participated in the discussion for this and looked at the most recent version of this KIP. It looks good to me.
-- Divij Vaidya On Tue, Jan 23, 2024 at 8:17 AM David Jacot <dja...@confluent.io.invalid> wrote: > Hi Chris, Ziming, > > Thanks for the clarification. I am glad that it does not impact the tool. > It may be worth adding a note about it in the KIP to avoid the same > question in the future. > > Otherwise, I am +1 (binding). Thanks for driving this! > > Best, > David > > On Tue, Jan 23, 2024 at 6:07 AM ziming deng <dengziming1...@gmail.com> > wrote: > > > Hello David, > > > > Thanks for reminding this, as Chirs explained, the tools I’m trying to > > update only support set/delete configs, and I’m just make a way for > > append/subtract configs in the future, so this would not be affected by > > KAFKA-10140, and it would be a little overkill to support append/subtract > > configs or solve KAFKA-10140 here, so let’s leave it right now, I'm happy > > to pick it after finishing this KIP. > > > > --, > > Ziming > > > > > On Jan 22, 2024, at 18:23, David Jacot <dja...@confluent.io.INVALID> > > wrote: > > > > > > Hi Ziming, > > > > > > Thanks for driving this. I wanted to bring KAFKA-10140 > > > <https://issues.apache.org/jira/browse/KAFKA-10140> to your attention. > > It > > > looks like the incremental API does not work for configuring plugins. I > > > think that we need to cover this in the KIP. > > > > > > Best, > > > David > > > > > > On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield < > > > andrew_schofield_j...@outlook.com> wrote: > > > > > >> +1 (non-binding) > > >> > > >> Thanks, > > >> Andrew > > >> > > >>> On 22 Jan 2024, at 07:29, Federico Valeri <fedeval...@gmail.com> > > wrote: > > >>> > > >>> +1 (non binding) > > >>> > > >>> Thanks. > > >>> > > >>> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen <show...@gmail.com> wrote: > > >>>> > > >>>> Hi Ziming, > > >>>> > > >>>> +1(binding) from me. > > >>>> > > >>>> Thanks. > > >>>> Luke > > >>>> > > >>>> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash < > > >>>> kamal.chandraprak...@gmail.com> wrote: > > >>>> > > >>>>> +1 (non-binding) > > >>>>> > > >>>>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng < > > dengziming1...@gmail.com> > > >>>>> wrote: > > >>>>> > > >>>>>> Hello everyone, > > >>>>>> I'd like to initiate a vote for KIP-1011. > > >>>>>> This KIP is about replacing alterConfigs with > > incrementalAlterConfigs > > >>>>>> when updating broker configs using kafka-configs.sh, this is > similar > > >> to > > >>>>>> what we have done in KIP-894. > > >>>>>> > > >>>>>> KIP link: > > >>>>>> KIP-1011: Use incrementalAlterConfigs when updating broker configs > > by > > >>>>>> kafka-configs.sh - Apache Kafka - Apache Software Foundation > > >>>>>> < > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh > > >>> > > >>>>>> cwiki.apache.org > > >>>>>> < > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh > > >>> > > >>>>>> [image: favicon.ico] > > >>>>>> < > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh > > >>> > > >>>>>> < > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh > > >>> > > >>>>>> > > >>>>>> Discussion thread: > > >>>>>> > > >>>>>> > > >>>>>> lists.apache.org > > >>>>>> <https://lists.apache.org/thread/xd28mgqy75stgsvp6qybzpljzflkqcsy > > > > >>>>>> <https://lists.apache.org/thread/xd28mgqy75stgsvp6qybzpljzflkqcsy > > > > >>>>>> <https://lists.apache.org/thread/xd28mgqy75stgsvp6qybzpljzflkqcsy > > > > >>>>>> > > >>>>>> > > >>>>>> --, > > >>>>>> Best, > > >>>>>> Ziming > > >> > > >> > > >> > > > > >
