> On Aug. 13, 2014, 4:28 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, > > lines 61-68 > > <https://reviews.apache.org/r/24196/diff/5/?file=658862#file658862line61> > > > > Do we need to do the pattern matching here? Can we just remove based on > > clientId itself?
The clientId in FetchRequestAndResponseStats comes from clientId+"-ConsumerFetcherThread-%s-%d-%d".format(consumerIdString, fetcherId, sourceBroker.id). Because a single clientId for a consumer can have multiple consumer thread registered in the registry, it has to be a regex match. But it may be better to change the pattern to clientId+"ConsumerFetcherThread-.*", so it will be different from replica fetcher thread. - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50401 ----------------------------------------------------------- On Aug. 12, 2014, 10:20 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24196/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 10:20 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1567 > https://issues.apache.org/jira/browse/KAFKA-1567 > > > Repository: kafka > > > Description > ------- > > Changed to use more precise regex for metric names. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerTopicStats.scala > ff5f470f7aa304917d3295fcb7702291ce7fe0b5 > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala > 875eeeb73cba5bd034349f5e7b6e16dfdf544254 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > 65f518d47c7555c42c4bff39c211814831f4b8b6 > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala > a20ab90165cc7ebb1cf44078efe23a53938c8df6 > core/src/main/scala/kafka/producer/Producer.scala > 4798481d573bbdce0ba39035c50f4c4411ad0469 > core/src/main/scala/kafka/producer/ProducerRequestStats.scala > 96942205a6a461e122e003add1ab9bcebde1fe16 > core/src/main/scala/kafka/producer/ProducerStats.scala > e1610d3c602fb0f5f4cc237cb8b4e0d168a41530 > core/src/main/scala/kafka/producer/ProducerTopicStats.scala > ed209f4773dedb09e9a34005e6849730229aa6e9 > > Diff: https://reviews.apache.org/r/24196/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
