> On Aug. 13, 2014, 4:51 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 163 > > <https://reviews.apache.org/r/24196/diff/6/?file=659348#file659348line163> > > > > This trace message is going to be a bit hard to understand. It's not > > clear what those two numbers are. Also, registeredMetric is not changing > > per iteration. If we want to log it in trace, should we log it before the > > loop? > > Jiangjie Qin wrote: > The trace message was meant to serve 2 purposes: > 1. Verify whether each of the metrics in the metric name set got a match > and removed. The registeredMetric is the MetricName being removed and > actually changes per iteration. > 2. Tells the number of metrics that are registered in yammer registry. > Maybe I can change the val name to "numRegisteredMetricsBeforeRemoval" > and "numRegisteredMetricsAfterRemoval".
Ok, perhaps we can change the log to sth like "Removing metric %s. Metrics registry size is reduced from %d to %d".format(registeredMetric, beforeRemovalSize, afterRemovalSize). - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50462 ----------------------------------------------------------- On Aug. 13, 2014, 3:26 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24196/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 3:26 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1567 > https://issues.apache.org/jira/browse/KAFKA-1567 > > > Repository: kafka > > > Description > ------- > > Changed regex in removeFetchRequestAndResponseStats(); modified comments in > KafkaMetricsGroup; > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerTopicStats.scala > ff5f470f7aa304917d3295fcb7702291ce7fe0b5 > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala > 875eeeb73cba5bd034349f5e7b6e16dfdf544254 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > 65f518d47c7555c42c4bff39c211814831f4b8b6 > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala > a20ab90165cc7ebb1cf44078efe23a53938c8df6 > core/src/main/scala/kafka/producer/Producer.scala > 4798481d573bbdce0ba39035c50f4c4411ad0469 > core/src/main/scala/kafka/producer/ProducerRequestStats.scala > 96942205a6a461e122e003add1ab9bcebde1fe16 > core/src/main/scala/kafka/producer/ProducerStats.scala > e1610d3c602fb0f5f4cc237cb8b4e0d168a41530 > core/src/main/scala/kafka/producer/ProducerTopicStats.scala > ed209f4773dedb09e9a34005e6849730229aa6e9 > > Diff: https://reviews.apache.org/r/24196/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
