Thank you Luke for taking a look at the KIP. I have corrected the typo and taken the suggestion of including replication states for inactive observers when "–include-inactive-observers" option is used with " kafka-metadata-quorum.sh describe --replication", as this might be useful for finding out how long an observer node has been inactive.
Regards, Gantigmaa On Thu, Aug 8, 2024 at 9:31 AM Luke Chen <show...@gmail.com> wrote: > Hi Gantigmaa, > > Thanks for the KIP! > The motivation and change looks good to me. > > Some comments: > 1. typo: When a KRaft broker node shuts down, it is in "fenced" state, not > "unfenced" state > 2. Will the "–include-inactive-observers" option apply to " > kafka-metadata-quorum.sh describe --replication"? > I don't think we must have it, but maybe it's useful to let users know the > offset lag for the inactive observers? > > Thank you. > Luke > > On Thu, Jul 25, 2024 at 9:21 PM Gantigmaa Selenge <gsele...@redhat.com> > wrote: > > > Hi everyone, > > > > I would like to start a discussion on KIP-1073 that includes inactive > > observer nodes in the response for describeQuorum request. > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1073%3A+Return+inactive+observer+nodes+in+DescribeQuorum+response > > > > The initial discussion on this issue is here, if you would like to see > what > > was previously discussed: > > https://lists.apache.org/list.html?dev@kafka.apache.org > > > > Any feedback and suggestions for the KIP are welcome in this email > thread. > > > > Thank you. > > Regards, > > Gantigmaa Selenge > > >
