On Fri, Aug 9, 2024, at 14:46, Colin McCabe wrote: > Hi Gantigmaa, > > I agree with you that we need a way to list fenced brokers. > > However, I don't think this KIP is the right way to do that. This KIP, > if I understand correctly, is about listing all Raft observers. The > broker is one example of a Raft observer, but there may be others. For > example, the metadata shell is supposed to be able to connect to the > quorum and read the current metadata. (I think this feature was > disabled for now because we didn't have enough time to finish it, but > it's in the design.) > > Even worse, if the fenced broker is down (not runninng), it will not > show up as a Raft observer at all. Therefore, you won't be able to do > what you want with this KIP in its current form.
Actually, to drill down on this a bit: I think inactive observers might show up in some scenarios, but not all. Like if you roll the controller cluster, that in-memory state will probably get lost. In any case, my point remains: this isn't the right way. best, Colin > > A better idea would be to add a flag to DescribeClusterRequest that > allowed us to list fenced brokers. You would also want to add a > corresponding isFenced field to each broker's information in > DescribeClusterResponse. > > Then you would probably add something like a list-brokers action to the > kafka-cluster.sh command line. It makes more sense to put it there > anyway, since that's where unregister is. > > best, > Colin > > > On the thread you linked, you pointed > > On Thu, Aug 8, 2024, at 09:56, Gantigmaa Selenge wrote: >> Thank you Luke for taking a look at the KIP. >> >> I have corrected the typo and taken the suggestion of including replication >> states for inactive observers when "–include-inactive-observers" option is >> used with " >> kafka-metadata-quorum.sh describe --replication", as this might be useful >> for finding out how long an observer node has been inactive. >> >> Regards, >> Gantigmaa >> >> On Thu, Aug 8, 2024 at 9:31 AM Luke Chen <show...@gmail.com> wrote: >> >>> Hi Gantigmaa, >>> >>> Thanks for the KIP! >>> The motivation and change looks good to me. >>> >>> Some comments: >>> 1. typo: When a KRaft broker node shuts down, it is in "fenced" state, not >>> "unfenced" state >>> 2. Will the "–include-inactive-observers" option apply to " >>> kafka-metadata-quorum.sh describe --replication"? >>> I don't think we must have it, but maybe it's useful to let users know the >>> offset lag for the inactive observers? >>> >>> Thank you. >>> Luke >>> >>> On Thu, Jul 25, 2024 at 9:21 PM Gantigmaa Selenge <gsele...@redhat.com> >>> wrote: >>> >>> > Hi everyone, >>> > >>> > I would like to start a discussion on KIP-1073 that includes inactive >>> > observer nodes in the response for describeQuorum request. >>> > >>> > >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1073%3A+Return+inactive+observer+nodes+in+DescribeQuorum+response >>> > >>> > The initial discussion on this issue is here, if you would like to see >>> what >>> > was previously discussed: >>> > https://lists.apache.org/list.html?dev@kafka.apache.org >>> > >>> > Any feedback and suggestions for the KIP are welcome in this email >>> thread. >>> > >>> > Thank you. >>> > Regards, >>> > Gantigmaa Selenge >>> > >>>
