Hi, Thanks for the KIP. A few comments:
1. Incompatible changes are generally not allowed in minor releases. Are you proposing a change for a minor release (eg 4.1) or for a major release (5.0)? 2. Given that clients in 4.0 support brokers with version 2.1 or higher, `offsetsForTimes` should never return maps with `null` values (check the javadoc for the details of when this happens). We can perhaps consider this a documentation fix (versus a behavior change). 3. The other methods specified in the `public interfaces` section don't specify if the returned maps can contain `null`. Can they? If so, we should make that clear in the KIP along with the details of how we intend to make the change in a compatible way. Thanks, Ismael On Fri, Mar 14, 2025 at 4:31 AM 黃竣陽 <s7133...@gmail.com> wrote: > Hello everyone, > > I would like to start a discussion on KIP-1140: Avoid to return null value > in Map from public api of consumer > <https://cwiki.apache.org/confluence/x/mIuMEw> > > This proposal aims to improve the Kafka consumer API by ensuring that the > Map it returns contains only non-null values, > aligning with the design philosophy of Java collections. This change > provides significantly more benefits than drawbacks, > enhancing API consistency and usability while reducing errors caused by > developer misuse. > > Best Regards, > Jiunn-Yang
