"But value is the average ratio over the polling interval" If we look at it in that way, using the average makes sense to me. I've updated the KIP.
Thanks Joe for the clarification. Mahsa Seifikar On Tue, Aug 19, 2025 at 10:26 AM José Armando García Sancio <jsan...@confluent.io.invalid> wrote: > Thanks for the update Mahsa. > > On Mon, Aug 18, 2025 at 12:59 PM Mahsa Seifikar > <mseifi...@confluent.io.invalid> wrote: > > > "How about just calling it AvgIdleRatio?" > > I think it's better to avoid using "Avg" because the metric is not a true > > average, which could be misleading. We have a similar confusion with > > "poll-idle-ratio-avg" metric. Although its description was updated in > this > > PR > > < > https://github.com/apache/kafka/pull/13207/files#diff-c332d2f026c35319f91aa0fefbb449d0721af93eb44578a701058ee990908947R139 > >, > > the name itself still causes confusion. > > I have changed the name to ThreadIdleRatio. Let me know what you think. > > But value is the average ratio over the polling interval. If you look > at the code, it sums the durations. TimeRatio's measure function > doesn't return the max ratio or the min ratio for example. > > Thanks, > -- > -José >
