[
https://issues.apache.org/jira/browse/KAFKA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136754#comment-14136754
]
Jun Rao commented on KAFKA-1620:
--------------------------------
Thanks for the new patch. Similarly, do we need to make RequestOrResponse
public since it's just an abstract base class?
> Make kafka api protocol implementation public
> ---------------------------------------------
>
> Key: KAFKA-1620
> URL: https://issues.apache.org/jira/browse/KAFKA-1620
> Project: Kafka
> Issue Type: Improvement
> Reporter: Anton Karamanov
> Assignee: Anton Karamanov
> Attachments:
> 0001-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch,
> 0002-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch
>
>
> Some of the classes which implement Kafka api protocol, such as
> {{RequestOrResponse}} and {{FetchRequest}} are defined as private to
> {{kafka}} package. Those classes would be extremely usefull for writing
> custom clients (we're using Scala with Akka and implementing one directly on
> top of Akka TCP), and don't seem to contain any actuall internal logic of
> Kafka. Therefore it seems like a nice idea to make them public.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
