[ https://issues.apache.org/jira/browse/KAFKA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136817#comment-14136817 ]
Anton Karamanov commented on KAFKA-1620: ---------------------------------------- Yes, it is actually one of the primary motives for this issue, since it allows to abstract from specific requests/responses on a low level. Without a common class any generic collection of messages would have to have a type of {{Collection[Any]}} reducing type safety and making it harder to control the flow of requests/responses. > Make kafka api protocol implementation public > --------------------------------------------- > > Key: KAFKA-1620 > URL: https://issues.apache.org/jira/browse/KAFKA-1620 > Project: Kafka > Issue Type: Improvement > Reporter: Anton Karamanov > Assignee: Anton Karamanov > Attachments: > 0001-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch, > 0002-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch > > > Some of the classes which implement Kafka api protocol, such as > {{RequestOrResponse}} and {{FetchRequest}} are defined as private to > {{kafka}} package. Those classes would be extremely usefull for writing > custom clients (we're using Scala with Akka and implementing one directly on > top of Akka TCP), and don't seem to contain any actuall internal logic of > Kafka. Therefore it seems like a nice idea to make them public. -- This message was sent by Atlassian JIRA (v6.3.4#6332)