Hi Jiunn-Yang,
A few more comments I'm afraid.

AS12: I see that you've added the group creation time to 
bin/kafka-consumer-groups.sh --describe --state. This seems to me like a very 
detailed piece of information which clutters the output for normal users. Would 
it be more appropriate to add the new information to the --state --verbose 
output instead, as was done with the epochs?

AS13: Looking at the change for bin/kafka-consumer-groups.sh --reset-offset, I 
think  --to-start-time would be better than --by-start-time. We do have 
by-duration but that's relative to the current time. For the start time, you're 
setting to an absolute time which is the group's creation time. I know this 
would change the config, the command-line flag, and so on, so it's quite a 
pervasive change. This is just an opinion of course, so feel free to ignore it.

AS14: I expect that it's appropriate to make the same additions to 
bin/kafka-streams-groups.sh as in AS12/13.

Thanks,
Andrew

On 2026/04/10 17:41:33 黃竣陽 wrote:
> Hello chia,
> 
> Thanks for your suggestions,
> 
> I have added following changes for kafka-consumer-groups.sh
> * --describe --state gains a GROUP-CREATION-TIME column displaying 
> the group creation timestamp in ISO-8601 UTC format.
> 
> * --reset-offsets gains a new --by-start-time option that uses the group 
> creation timestamp as the reference point for ListOffsets.
> 
> Best Regards
> Jiunn-Yang
> 
> > Chia-Ping Tsai <[email protected]> 於 2026年4月11日 凌晨12:54 寫道:
> > 
> > should `kafka-consumer-groups.sh` support the new policy?
> 
> 

Reply via email to