----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review56989 -----------------------------------------------------------
This is a fairly tricky patch and I'm not 100% sure that we haven't introduced any kind of regression. I'd feel more comfortable accepting this patch, if we repeated the kind of testing that was done to find this bug. core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment97429> if(!partition.makeFollower) core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment97430> Now for partitions that have a leader, we are not adding a follower. - Neha Narkhede On Oct. 13, 2014, 11:38 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26373/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 11:38 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1647 > https://issues.apache.org/jira/browse/KAFKA-1647 > > > Repository: kafka > > > Description > ------- > > Addressed Joel's comments. > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 78b7514cc109547c562e635824684fad581af653 > > Diff: https://reviews.apache.org/r/26373/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
