> On Oct. 16, 2014, 6:10 p.m., Neha Narkhede wrote:
> > Since you fixed some other tools as well, can we also fix the preferred 
> > replica election command where we can de-dup the partitions?

This was already removing duplicates, I had it generate an exception instead 
since duplicates may indicate a config error. I'm assuming that's what you 
meant here.


- Ewen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26666/#review56958
-----------------------------------------------------------


On Oct. 16, 2014, 9:54 p.m., Ewen Cheslack-Postava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26666/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 9:54 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1653
>     https://issues.apache.org/jira/browse/KAFKA-1653
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Generate error for duplicates in PreferredLeaderElectionCommand instead of 
> just swallowing duplicates.
> 
> 
> Report which entries are duplicated for ReassignPartitionCommand since they 
> may be difficult to find in large reassignments.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 
> c7918483c02040a7cc18d6e9edbd20a3025a3a55 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 
> 691d69a49a240f38883d2025afaec26fd61281b5 
>   core/src/main/scala/kafka/admin/TopicCommand.scala 
> 7672c5aab4fba8c23b1bb5cd4785c332d300a3fa 
>   core/src/main/scala/kafka/tools/StateChangeLogMerger.scala 
> d298e7e81acc7427c6cf4796b445966267ca54eb 
> 
> Diff: https://reviews.apache.org/r/26666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ewen Cheslack-Postava
> 
>

Reply via email to