-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26666/
-----------------------------------------------------------
(Updated Oct. 21, 2014, 6:58 p.m.)
Review request for kafka.
Bugs: KAFKA-1653
https://issues.apache.org/jira/browse/KAFKA-1653
Repository: kafka
Description (updated)
-------
Generate error for duplicates in PreferredLeaderElectionCommand instead of just
swallowing duplicates.
Report which entries are duplicated for ReassignPartitionCommand since they may
be difficult to find in large reassignments.
Report duplicate topics and duplicate topic partitions in
ReassignPartitionsCommand. Make all duplication error messagse include details
about what item was duplicated.
Diffs (updated)
-----
core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala
c7918483c02040a7cc18d6e9edbd20a3025a3a55
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
691d69a49a240f38883d2025afaec26fd61281b5
core/src/main/scala/kafka/admin/TopicCommand.scala
7672c5aab4fba8c23b1bb5cd4785c332d300a3fa
core/src/main/scala/kafka/tools/StateChangeLogMerger.scala
d298e7e81acc7427c6cf4796b445966267ca54eb
core/src/main/scala/kafka/utils/Utils.scala
29d5a17d4a03cfd3f3cdd2994cbd783a4be2732e
core/src/main/scala/kafka/utils/ZkUtils.scala
a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12
Diff: https://reviews.apache.org/r/26666/diff/
Testing
-------
Thanks,
Ewen Cheslack-Postava
