----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58049 -----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment98952> Pre-existing naming issue that would be good to fix in this. At first glance, this is extremely confusing and looks wrong. DataChannel is defined as DataChannel(capacity, numProducers, numConsumers) It is instantiated on line 127 as new DataChannel(capacity, numConsumers, numProducers) i.e., it seems as though the arguments are switched. The consumers/producers parameters of the DataChannel are to be interpreted as inputs/outputs and have nothing to do with numConsumers/numProducers in the mirror maker. So, can you rename these fields in the DataChannel? i.e., numConsumers -> numOutputs and numProducers -> numInputs? - Joel Koshy On Oct. 22, 2014, 10:04 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26994/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 10:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1719 > https://issues.apache.org/jira/browse/KAFKA-1719 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comments. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > b8698ee1469c8fbc92ccc176d916eb3e28b87867 > > Diff: https://reviews.apache.org/r/26994/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
