> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > <https://reviews.apache.org/r/26994/diff/1/?file=727975#file727975line323> > > > > Is this change intended? > > Jiangjie Qin wrote: > Yes, it is intended, so that we can make sure each data channel queue > will receive a shutdown message. Otherwise 2 messages could go to the same > data channel queue. > > Joel Koshy wrote: > Is this true? Each put will go to the next queue. i.e., > Utils.abs(counter.getAndIncrement()) % numConsumers > So suppose there are 10 producers and you put 10 shutdown messages. Each > of those output queues will get exactly one shutdown message. > I have a separate comment on the existing code wrt naming which I will > put in the RB directly.
Hi Joel, yes, I think you are right, since there will be no other put during the shutting down pahse, though it is kind of wiered that when we call shutdown for 1 thread and the other one got shutdown... - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review57680 ----------------------------------------------------------- On Oct. 22, 2014, 10:04 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26994/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 10:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1719 > https://issues.apache.org/jira/browse/KAFKA-1719 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comments. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > b8698ee1469c8fbc92ccc176d916eb3e28b87867 > > Diff: https://reviews.apache.org/r/26994/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
