> On Nov. 7, 2014, 7:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, line 73 > > <https://reviews.apache.org/r/27684/diff/1/?file=751760#file751760line73> > > > > I'd add a comment on why we have two interfaces here, since its > > none-obvious and someone may try to refactor in the future... Perhaps link > > to the email thread?
Agreed. Added a comment. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60364 ----------------------------------------------------------- On Nov. 8, 2014, 6:20 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27684/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 6:20 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1743 > https://issues.apache.org/jira/browse/KAFKA-1743 > > > Repository: kafka > > > Description > ------- > > def commitOffsets method added to make ConsumerConnector backward compatible > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala > 07677c1c26768ef9c9032626180d0015f12cb0e0 > > Diff: https://reviews.apache.org/r/27684/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
