----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60375 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsumerConnector.scala <https://reviews.apache.org/r/27684/#comment101730> Can we instead do: def commitOffsets { commitOffsets(false) } so all implementations of the trait don't need to do the above. - Joel Koshy On Nov. 6, 2014, 5:13 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27684/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 5:13 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1743 > https://issues.apache.org/jira/browse/KAFKA-1743 > > > Repository: kafka > > > Description > ------- > > def commitOffsets method added to make ConsumerConnector backward compatible > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala > 07677c1c26768ef9c9032626180d0015f12cb0e0 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > fbc680fde21b02f11285a4f4b442987356abd17b > > Diff: https://reviews.apache.org/r/27684/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
