-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27684/#review61863
-----------------------------------------------------------
Thanks for the patch. Got the following compilation error.
:core:compileTestScala/Users/junrao/intellij/kafka/core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala:116:
overloaded method value commitOffsets with alternatives:
=> Unit <and>
(isAutoCommit: Boolean)Unit
cannot be applied to ()
zkConsumerConnector1.commitOffsets()
^
/Users/junrao/intellij/kafka/core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala:204:
overloaded method value commitOffsets with alternatives:
=> Unit <and>
(isAutoCommit: Boolean)Unit
cannot be applied to ()
zkConsumerConnector1.commitOffsets()
^
two errors found
FAILED
- Jun Rao
On Nov. 16, 2014, 6:42 a.m., Manikumar Reddy O wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27684/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2014, 6:42 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1743
> https://issues.apache.org/jira/browse/KAFKA-1743
>
>
> Repository: kafka
>
>
> Description
> -------
>
> def commitOffsets method added to make ConsumerConnector backward
> compatible; Addressing Jun's comments
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ConsumerConnector.scala
> 07677c1c26768ef9c9032626180d0015f12cb0e0
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
> f476973eeff653473a60c3ecf36e870e386536bc
> core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala
> 1f98db5d692adc113189ec8c75a4fad29d6b6ffe
>
> Diff: https://reviews.apache.org/r/27684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Manikumar Reddy O
>
>
