> On Nov. 14, 2014, 7:29 p.m., Jun Rao wrote: > > Thanks for the patch. For clarity, in ZookeeperConsumerConnector, instead > > of having the following, > > def commitOffsets(isAutoCommit: Boolean = true) > > > > could we break it into two separate methods, same as what's defined in > > ConsumerConnector?
Done. Added the following APIs in ZookeeperConsumerConnector. def commitOffsets(retryOnFailure: Boolean) def commitOffsets - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review61486 ----------------------------------------------------------- On Nov. 16, 2014, 6:42 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27684/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2014, 6:42 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1743 > https://issues.apache.org/jira/browse/KAFKA-1743 > > > Repository: kafka > > > Description > ------- > > def commitOffsets method added to make ConsumerConnector backward > compatible; Addressing Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala > 07677c1c26768ef9c9032626180d0015f12cb0e0 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > f476973eeff653473a60c3ecf36e870e386536bc > core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala > 1f98db5d692adc113189ec8c75a4fad29d6b6ffe > > Diff: https://reviews.apache.org/r/27684/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
