[ 
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294053#comment-14294053
 ] 

Jason Rosenberg commented on KAFKA-1902:
----------------------------------------

Since many people use the vanilla GraphiteReporter bundled with the yammer 
libraries, it's a bit of work to ask them to roll a custom Graphite reporter.  
Further, a custom reporter would have to embed specific knowledge around kafka 
metric scopes (while still supporting lots of general metrics coming from other 
libraries and the app itself).

Instead, if we don't want to create a reasonably formatted scope string that is 
already compatible with yammer metrics (which generally assumes the graphite 
format), it might work best if the scope string is sanitized to replace all 
dots with underscores.  This way, the scope is simply a unique (but still human 
identifiable) string, and is readily usable without too much guessing about a 
reasonable format.  The string would then be guaranteed to be a single, 
unbroken navigable component of a graphite metric.



> fix MetricName so that Yammer reporter can work correctly
> ---------------------------------------------------------
>
>                 Key: KAFKA-1902
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1902
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.8.2
>
>         Attachments: kafka-1902.patch
>
>
> Currently, we create MetricName in the following format.
> group: "kafka.server"
> type: "BrokerTopicMetrics"
> name: "BytesInPerSec"
> scope: null
> mBeanName: 
> "kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec,topic=test"
> However, Yammer metric reporter seems to only use the first four fields 
> group, type, name and scope during reporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to