[ 
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294309#comment-14294309
 ] 

Kyle Banker commented on KAFKA-1902:
------------------------------------

Couple ideas here:

1. [~junrao] For what its worth, the typical way of representing types in 
Graphite is with an extra level of hierarchy: i.e., instead of 
BrokerTopicMetrics.topic=foo, we'd do BrokerTopicMetrics.Topics.foo.

2. The character used to replace the dots in topic names could be configurable.

3. The default replacement could indeed be underscores. This is, I believe, the 
standard conventions used when a hostname is part of a Graphite metric: simply 
replace dots with underscores. (Note that although host names aren't allowed to 
have underscores in the real world, DNS names often do. Still, no confusion 
results).



> fix MetricName so that Yammer reporter can work correctly
> ---------------------------------------------------------
>
>                 Key: KAFKA-1902
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1902
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.8.2
>
>         Attachments: kafka-1902.patch
>
>
> Currently, we create MetricName in the following format.
> group: "kafka.server"
> type: "BrokerTopicMetrics"
> name: "BytesInPerSec"
> scope: null
> mBeanName: 
> "kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec,topic=test"
> However, Yammer metric reporter seems to only use the first four fields 
> group, type, name and scope during reporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to