[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294474#comment-14294474
]
Jun Rao commented on KAFKA-1902:
--------------------------------
Making the replacing character configurable is actually not very easy and I
think it's also a bit over killing. Do you know if the dot convention is
followed in other reporters like Ganglia?
If we do end up using the dot convention in scope name, I think we should use a
replacing character other than - or _. The reasoning is that if you see an
issue with a metric on a topic, you probably want to do some trouble-shooting
on the topic. If you can't figure out the exact topic, this will be a problem.
Yes, using $ is not very readable. However, it's probably better than not
figuring out the exact topic name. Also, this only affects the case when dot is
actually used in the tag value, which may not be common.
> fix MetricName so that Yammer reporter can work correctly
> ---------------------------------------------------------
>
> Key: KAFKA-1902
> URL: https://issues.apache.org/jira/browse/KAFKA-1902
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Jun Rao
> Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: kafka-1902.patch
>
>
> Currently, we create MetricName in the following format.
> group: "kafka.server"
> type: "BrokerTopicMetrics"
> name: "BytesInPerSec"
> scope: null
> mBeanName:
> "kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec,topic=test"
> However, Yammer metric reporter seems to only use the first four fields
> group, type, name and scope during reporting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
